Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(effects): remove unneeded critical div #3985

Closed
2 tasks
timdeschryver opened this issue Aug 3, 2023 · 1 comment · Fixed by #3986
Closed
2 tasks

docs(effects): remove unneeded critical div #3985

timdeschryver opened this issue Aug 3, 2023 · 1 comment · Fixed by #3986
Assignees
@KshitijTodkar48
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs Good First Issue Good issue for first-time contributor

Comments

@timdeschryver
Copy link
Member

Information

In #3854 we accidentally added a div, which makes all the content below it "critical".

image

The following line should be removed

platform/projects/ngrx.io/content/guide/effects/index.md

Line 373 in f371d9e

<div class="alert is-critical">

Documentation page

https://ngrx.io/guide/effects

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@timdeschryver timdeschryver added Comp: Docs Accepting PRs Good First Issue Good issue for first-time contributor labels Aug 3, 2023
@KshitijTodkar48
Copy link
Contributor

I want to fix this, can you assign this to me?

@brandonroberts brandonroberts added the community watch Someone from the community is working this issue/PR label Aug 3, 2023
@KshitijTodkar48 KshitijTodkar48 mentioned this issue Aug 4, 2023
Merged
2 tasks
timdeschryver pushed a commit that referenced this issue Aug 4, 2023
@KshitijTodkar48
docs(effects): remove unneeded critical div (#3986)
65acf86 
Closes #3985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KshitijTodkar48 KshitijTodkar48

Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs Good First Issue Good issue for first-time contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(effects): removed unneeded critical div (#3985)
3 participants
@brandonroberts @timdeschryver @KshitijTodkar48