Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): fix prefer-contact-latest-from rule to detect inject #3946

Merged

Conversation

va-stefanek
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently, the eslint plugin does not detect the actions, if it is injected via the new inject method

Related to #3943

Closes #3943

What is the new behavior?

Updated actions detection logic to also check for actions injected via inject method from the @angular/core package

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5c8097f
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/64a71e3329a19d00086e02e0
😎 Deploy Preview https://deploy-preview-3946--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @va-stefanek !

@markostanimirovic markostanimirovic changed the title fix(eslint): fix prefer-contact-latest-from rule to detect inject (#3943) fix(eslint-plugin): fix prefer-contact-latest-from rule to detect inject Jul 11, 2023
@markostanimirovic markostanimirovic merged commit 2efd805 into ngrx:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint-plugin: lint rules using inject()
3 participants