Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-plugin: lint rules using inject() #3943

Closed
15 of 16 tasks
timdeschryver opened this issue Jul 5, 2023 · 9 comments · Fixed by #3946 or #4022
Closed
15 of 16 tasks

eslint-plugin: lint rules using inject() #3943

timdeschryver opened this issue Jul 5, 2023 · 9 comments · Fixed by #3946 or #4022
Labels

Comments

@timdeschryver
Copy link
Member

timdeschryver commented Jul 5, 2023

Which @ngrx/* package(s) are relevant/related to the feature request?

eslint-plugin

Information

Linter rules that use instances injected within the constructor should also work using inject().
See #3936 for an example.

It could be that some implementations are already provided but we'll need to add tests for the other rules as well.

Drop your name here and mention which rule(s) you want to help with, if you want to help.

The list of rules that needs to be updates:

  • avoid-cyclic-effects ( @suke )
  • prefer-concat-latest-from ( @va-stefanek )
  • updater-explicit-return-type ( @suke )
  • no-dispatch-in-effects ( @va-stefanek )
  • avoid-combining-selectors ( @va-stefanek )
  • avoid-dispatching-multiple-actions-sequentially ( @va-stefanek )
  • avoid-mapping-selectors ( @va-stefanek )
  • no-multiple-global-stores ( @va-stefanek )
  • no-store-subscription
  • no-typed-global-store
  • prefer-action-creator-in-dispatch ( @suke )
  • prefer-selector-in-select ( @suke )
  • select-style ( @suke )
  • use-consistent-global-store-name ( @suke )

Describe any alternatives/workarounds you're currently using

There is no workaround.

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@va-stefanek
Copy link
Contributor

I can create no-dispatch-in-effects and prefer-concat-latest-from

@va-stefanek
Copy link
Contributor

va-stefanek commented Jul 7, 2023

@timdeschryver let's assign me to
avoid-combining-selectors
avoid-dispatching-multiple-actions-sequentially
avoid-mapping-selectors
no-multiple-global-stores

va-stefanek added a commit to va-stefanek/platform that referenced this issue Jul 7, 2023
va-stefanek added a commit to va-stefanek/platform that referenced this issue Jul 7, 2023
@timdeschryver timdeschryver reopened this Jul 11, 2023
va-stefanek added a commit to va-stefanek/platform that referenced this issue Jul 16, 2023
@suke
Copy link
Contributor

suke commented Jul 30, 2023

@timdeschryver please assign me select-style

@timdeschryver
Copy link
Member Author

Thanks @suke

@suke
Copy link
Contributor

suke commented Aug 1, 2023

@timdeschryver Please continue to assign
prefer-action-creator-in-dispatch
prefer-selector-in-select
use-consistent-global-store-name

@timdeschryver
Copy link
Member Author

Done @suke ! Thanks in advance.

@suke
Copy link
Contributor

suke commented Aug 15, 2023

@timdeschryver I will take on the remaining tasks!

@suke
Copy link
Contributor

suke commented Sep 1, 2023

@timdeschryver I'm sorry. I have been busy lately and have not been able to work on it.

@timdeschryver
Copy link
Member Author

@suke No problem! Your tremendous help, completed most of this issue. Thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants