-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eslint-plugin: lint rules using inject() #3943
Comments
I can create no-dispatch-in-effects and prefer-concat-latest-from |
@timdeschryver let's assign me to |
… to detect inject (ngrx#3943)
…ly rule to detect inject (ngrx#3943)
@timdeschryver please assign me |
Thanks @suke |
@timdeschryver Please continue to assign |
Done @suke ! Thanks in advance. |
@timdeschryver I will take on the remaining tasks! |
@timdeschryver I'm sorry. I have been busy lately and have not been able to work on it. |
@suke No problem! Your tremendous help, completed most of this issue. Thanks for that! |
Which @ngrx/* package(s) are relevant/related to the feature request?
eslint-plugin
Information
Linter rules that use instances injected within the constructor should also work using
inject()
.See #3936 for an example.
It could be that some implementations are already provided but we'll need to add tests for the other rules as well.
Drop your name here and mention which rule(s) you want to help with, if you want to help.
The list of rules that needs to be updates:
Describe any alternatives/workarounds you're currently using
There is no workaround.
I would be willing to submit a PR to fix this issue
The text was updated successfully, but these errors were encountered: