You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Through Angular DevTools, start the profiler in the example
The profiler will show a lot of change detection events caused by Window.addEventListener:message
Remove StoreDevtoolsModule.instrument({}), repeat step 3, the change detection events won't show up anymore
Minimal reproduction of the bug/regression with instructions
It's expected that the StoreDevtools doesn't trigger any change detection.
Change detection can be costly if any component do some kind of 'heavy work' like rendering multiple components with ngForOf, even if StoreDevtools logs only in development, it's still a big overhead for a development environment, depending on the size and complexity of the project.
Versions of NgRx, Angular, Node, affected browser(s) and operating system(s)
NgRx: 15.4.0
Angular: 15.2.3
Node: 16.16
Browser: Microsoft Edge 112.0.1722.34 (64-bit)
Operating system: Windows 10
Other information
I would be willing to submit a PR to fix this issue
Yes
No
The text was updated successfully, but these errors were encountered:
Which @ngrx/* package(s) are the source of the bug?
store-devtools
Minimal reproduction of the bug/regression with instructions
StoreDevtoolsModule.instrument({})
to app.module.ts, just like in the exampleWindow.addEventListener:message
StoreDevtoolsModule.instrument({})
, repeat step 3, the change detection events won't show up anymoreMinimal reproduction of the bug/regression with instructions
It's expected that the
StoreDevtools
doesn't trigger any change detection.Change detection can be costly if any component do some kind of 'heavy work' like rendering multiple components with
ngForOf
, even ifStoreDevtools
logs only in development, it's still a big overhead for a development environment, depending on the size and complexity of the project.Versions of NgRx, Angular, Node, affected browser(s) and operating system(s)
NgRx: 15.4.0
Angular: 15.2.3
Node: 16.16
Browser: Microsoft Edge 112.0.1722.34 (64-bit)
Operating system: Windows 10
Other information
I would be willing to submit a PR to fix this issue
The text was updated successfully, but these errors were encountered: