Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): make reducers arg of StoreModule.forRoot optional #3632

Merged

Conversation

markostanimirovic
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Importing StoreModule.forRoot without initial reducers is done in the following way:

imports: [
  StoreModule.forRoot({}),
]

What is the new behavior?

Importing StoreModule.forRoot without initial reducers can be also done as follows:

imports: [
  StoreModule.forRoot(),
]

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@netlify
Copy link

netlify bot commented Oct 24, 2022

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 67254da
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/63568e229337b400086be9c2

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@brandonroberts brandonroberts merged commit e5177aa into ngrx:master Oct 28, 2022
alex-okrushko added a commit that referenced this pull request Oct 28, 2022
* feat(component-store): Add SelectorObject

* use legacyFakeTimers

* adjust based on the feedback

* restrict to Observable

* feat(store): make reducers arg of StoreModule.forRoot optional (#3632)

* feat(schematics): drop support for TypeScript <4.8 (#3631)

* add support for an array state obj

Co-authored-by: Alex Okrushko <[email protected]>
Co-authored-by: Marko Stanimirović <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants