-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use schematicCollections
instead of defaultCollection
#3383
Comments
May I work on this issue? |
@suke Sure! |
@suke This can only be done once we've updated Angular to v14 (because that release includes the |
OK! I will work on it when Angular v14 is released! |
@suke We've updated the repo to use Angular 14, feel free to work on this. |
@timdeschryver I would like to discuss a specification. https://github.com/ngrx/platform/blob/master/modules/schematics/src/ng-add/schema.json#L6 |
Yes, that's a good idea! |
If |
I think throwing would be better, it probably means that the user didn't upgrade Angular. |
I understand. |
Information
In Angular 14, the
defaultCollection
is deprecated in favor ofschematicCollections
, which supports an array of schematics (instead of a single one).We should update the NgRx schematics to add the ngrx schematics to the collection, instead of overwriting the
defaultCollection
option.See angular/angular-cli#22860 for more info.
The code that does this is located at https://github.com/ngrx/platform/blob/master/modules/schematics/src/ng-add/index.ts.
Describe any alternatives/workarounds you're currently using
If you want to pick this issue up, please add a comment below :)
I would be willing to submit a PR to fix this issue
The text was updated successfully, but these errors were encountered: