-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide setMany
adapter for @ngrx/entity
#3026
Comments
Hey, we already have a |
@timdeschryver
Would you reconsider the proposal? Even though there is Copying from the docs:
So the functionality of |
Now, that's a whole different story 😅 |
@timdeschryver thanks for allowing this move forward! 😄 I've submitted a PR, please let me know if there is anything left |
setAll
replaces the whole collection. If an entity is not provided there, it will be removed. However, the feature request for a newsetMany
would act like:Copying from the docs:
Even though there is
updateMany
/upsertMany
, those do a partial update. The requestedsetMany
would do a replacement.Describe any alternatives/workarounds you're currently using
Custom entity adapter extension or a loop on
setOne
.Other information:
We have a scenario where we want to set only a subset of entities, so
setAll
wouldn't work. This would align withremove
,update
andupsert
.If accepted, I would be willing to submit a PR for this feature
[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
The text was updated successfully, but these errors were encountered: