Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): forFeature using instanceof instead of typeof #2922

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Feb 11, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2919

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The local build of this PR, works on the reprodution repo

Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this didn't fail when we build the libraries 🤔

Copy link

@bbortt bbortt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checked it out and it does indeed fix my issue - you guys are awesome 🚀

@timdeschryver
Copy link
Member Author

I have no idea why... I even tried with the upgrade to v11.2, but the behavior was the same.

@brandonroberts brandonroberts merged commit 2bea205 into master Feb 12, 2021
@timdeschryver timdeschryver deleted the fix-2919 branch February 13, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ngrx/store v11 throws a compilation error
3 participants