fix(store): forFeature using instanceof instead of typeof (#2922)

Closes #2919
ngrx · Feb 12, 2021 · 2bea205 · 2bea205
1 parent 775c794
commit 2bea205
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/modules/store/src/store_module.ts b/modules/store/src/store_module.ts
@@ -221,16 +221,16 @@ export class StoreModule {
         {
           provide: _FEATURE_CONFIGS,
           multi: true,
-          useValue: typeof featureNameOrSlice === 'string' ? config : {},
+          useValue: featureNameOrSlice instanceof Object ? {} : config,
         },
         {
           provide: STORE_FEATURES,
           multi: true,
           useValue: {
             key:
-              typeof featureNameOrSlice === 'string'
-                ? featureNameOrSlice
-                : featureNameOrSlice.name,
+              featureNameOrSlice instanceof Object
+                ? featureNameOrSlice.name
+                : featureNameOrSlice,
             reducerFactory:
               !(config instanceof InjectionToken) && config.reducerFactory
                 ? config.reducerFactory
@@ -254,9 +254,9 @@ export class StoreModule {
           provide: _FEATURE_REDUCERS,
           multi: true,
           useValue:
-            typeof featureNameOrSlice === 'string'
-              ? reducersOrConfig
-              : featureNameOrSlice.reducer,
+            featureNameOrSlice instanceof Object
+              ? featureNameOrSlice.reducer
+              : reducersOrConfig,
         },
         {
           provide: _FEATURE_REDUCERS_TOKEN,