Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for autoPause option #2722

Closed
felixschorer opened this issue Sep 25, 2020 · 3 comments · Fixed by #2941
Closed

Add support for autoPause option #2722

felixschorer opened this issue Sep 25, 2020 · 3 comments · Fixed by #2941
Labels
Accepting PRs community watch Someone from the community is working this issue/PR enhancement Project: Store Devtools

Comments

@felixschorer
Copy link

We've recently introduced NgRx into one of our applications. As our state object grows very large in our integration environment, we needed to deactivate the NgRx devtools. This was necessary as the overhead of sending the state to devtools brought the application to a crawl. The performance hit is caused by serializing the state object to JSON. This is done by the Redux Devtools Extension itself.

The Redux Devtools Extension has a feature to automatically pause recording the state when the devtools are closed. This reduces the overhead to zero as long as the devtools are closed.
This feature can be activated by setting autoPause: true in the options object.

It is currently not possible to set autoPause: true using the StoreDevtoolsModule.

Describe any alternatives/workarounds you're currently using

N/A. Disabling the devtools is currently the only option.

Other information:

It is not possible to reduce the size of our state object.

If accepted, I would be willing to submit a PR for this feature

[ x ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

@timdeschryver
Copy link
Member

Do you want to create a Pull Request for this @felixschorer ?

@felixschorer
Copy link
Author

felixschorer commented Oct 1, 2020

@timdeschryver I've created a task for that in our issue tracker.
However, we're still using Angular 8. We will have to upgrade first before we can work on this.

@timdeschryver timdeschryver added the community watch Someone from the community is working this issue/PR label Oct 1, 2020
@timdeschryver
Copy link
Member

Fyi @felixschorer, you can also use the blocklist for now to exclude those bigger actions.

https://ngrx.io/guide/store-devtools/config#actionssafelist--actionsblocklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepting PRs community watch Someone from the community is working this issue/PR enhancement Project: Store Devtools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants