Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ngrx/component add schematics #2450

Closed
4 of 10 tasks
BioPhoton opened this issue Mar 25, 2020 · 1 comment
Closed
4 of 10 tasks

@ngrx/component add schematics #2450

BioPhoton opened this issue Mar 25, 2020 · 1 comment

Comments

@BioPhoton
Copy link
Contributor

BioPhoton commented Mar 25, 2020

ngrx/components schematics

Implement schematics and migration scripts for the new features of ngrx/component.

Related: #2441

Todos

  • Implement schematics
    • ng add @ngrx/components
  • Implement migration scripts
    • factor-rule to replace async with ngrxPush see angular/material example
    • factor-rule to replace *ngIf="value$ | async as value" with *ngrxLet="value$; let value" (TO EVALUATE)
  • Implement tests
    • TODO checkout how current tests are done
  • Docs

If accepted, I would be willing to submit a PR for this feature

[X] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

@brandonroberts
Copy link
Member

Fixed via #2611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants