Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@ngrx/data] - wrong type of filter$ #2337

Closed
b-shanovskyi-andersen opened this issue Jan 28, 2020 · 1 comment · Fixed by #2349
Closed

[@ngrx/data] - wrong type of filter$ #2337

b-shanovskyi-andersen opened this issue Jan 28, 2020 · 1 comment · Fixed by #2349
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Project: Data

Comments

@b-shanovskyi-andersen
Copy link

Minimal reproduction of the bug/regression with instructions:

In EntityCollectionServiceBase:

/** Observable of the filter pattern applied by the entity collection's filter function */
filter$: Observable<string> | Store<string>;

But filter can have any type:

/**
  * Set the pattern that the collection's filter applies
  * when using the `filteredEntities` selector.
  */
setFilter(pattern: any): void;

Expected behavior:

filter$: Observable<any> | Store<any>;

I would be willing to submit a PR to fix this issue

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[X] No

@santoshyadavdev
Copy link
Contributor

Hi @timdeschryver/ @brandonroberts ,
I will work on it.

@timdeschryver timdeschryver added the community watch Someone from the community is working this issue/PR label Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Project: Data
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants