Platform: Update usage of TestBed.get to TestBed.inject #2240
Assignees
Labels
Comments
|
Hey, I wanna do this. |
brandonroberts
added
the
community watch
|
@sumitparakh It's yours. Let us know if you need any assistance |
|
Hi @brandonroberts , This update requires angular 9 and i see that currently ngrx is not upgraded to Angular 9.. Is there any other issue regarding Angular upgrade or should i upgrade to Angular 9 in this PR itself? |
|
Angular 9 update is in progress @timdeschryver is already on it. |
|
Alright. So I'll wait for that update and then continue with this PR |
sumitparakh
added a commit
to sumitparakh/platform
that referenced
this issue
Jan 8, 2020
angular 9 compatibillity changes for TestBed Closes ngrx#2240
3 tasks
sumitparakh
added a commit
to sumitparakh/platform
that referenced
this issue
Jan 8, 2020
TestBed.get replaced by TestBed.inject Closes #ngrx#2240
sumitparakh
added a commit
to sumitparakh/platform
that referenced
this issue
Jan 10, 2020
# This is the 1st commit message: test(component): update usage of TestBed.get to TestBed.inject angular 9 compatibillity changes for TestBed Closes ngrx#2240 # This is the commit message ngrx#2: test(docs): test cases updated in docs TestBed.get replaced by TestBed.inject Closes #ngrx#2240 # This is the commit message ngrx#3: test(component): example tests type fixed TestBed.get replace by TestBed.inject done # This is the commit message ngrx#4: test(component): test issue fixed angular 9 test upgrade changes done # This is the commit message ngrx#5: test(component): changes under docs folder is reverted angular 9 test upgrade changes # This is the commit message ngrx#6: test(component): src tests changes reverted angular 9 test upgrade changes
sumitparakh
added a commit
to sumitparakh/platform
that referenced
this issue
Jan 10, 2020
angular 9 compatibillity changes for TestBed Closes ngrx#2240 test(docs): test cases updated in docs TestBed.get replaced by TestBed.inject Closes #ngrx#2240 test(component): example tests type fixed TestBed.get replace by TestBed.inject done test(component): test issue fixed angular 9 test upgrade changes done test(component): changes under docs folder is reverted angular 9 test upgrade changes test(component): src tests changes reverted angular 9 test upgrade changes test(component): reverted unnecessary testing changes content folder changes are kept changes test(component): update usage of TestBed.get to TestBed.inject angular 9 compatibillity changes for TestBed Closes ngrx#2240 test(docs): test cases updated in docs TestBed.get replaced by TestBed.inject Closes #ngrx#2240 test(component): example tests type fixed TestBed.get replace by TestBed.inject done test(component): test issue fixed angular 9 test upgrade changes done test(component): changes under docs folder is reverted angular 9 test upgrade changes test(component): src tests changes reverted angular 9 test upgrade changes test(component): reverted unnecessary testing changes content folder changes are kept changes
sumitparakh
added a commit
to sumitparakh/platform
that referenced
this issue
Jan 10, 2020
angular 9 compatibillity changes for TestBed Closes ngrx#2240
sumitparakh
added a commit
to sumitparakh/platform
that referenced
this issue
Jan 11, 2020
test cases updated in content folder only Closes ngrx#2240
brandonroberts
pushed a commit
that referenced
this issue
Jan 12, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TestBed.injectreplacesTestBed.get<Type>. We need to clean up:Blocked by #2234
The text was updated successfully, but these errors were encountered: