Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example: Remove dispatching of 2 actions in AppComponent #2186

Closed
brandonroberts opened this issue Oct 28, 2019 · 0 comments · Fixed by #2189
Closed

Example: Remove dispatching of 2 actions in AppComponent #2186

brandonroberts opened this issue Oct 28, 2019 · 0 comments · Fixed by #2189
Labels
Accepting PRs Good First Issue Good issue for first-time contributor Project: Example App

Comments

@brandonroberts
Copy link
Member

In the example app, we dispatching 2 actions when the logout nav item is clicked, one to close the sidenav and one to display the logout confirmation. This should be done with one action, with the layout reducer listening for the logout confirmation action.

https://github.com/ngrx/platform/blob/master/projects/example-app/src/app/core/containers/app.component.ts#L65

https://github.com/ngrx/platform/blob/master/projects/example-app/src/app/core/reducers/layout.reducer.ts#L18
jordanpowell88 added a commit to jordanpowell88/platform that referenced this issue Oct 29, 2019
@jordanpowell88
refactor(example): add layout effect to listen for logoutConfirmation…
da34e25 
… and dispatch closeSidenav

Closes ngrx#2186
@jordanpowell88 jordanpowell88 mentioned this issue Oct 29, 2019
Merged
3 tasks
jordanpowell88 added a commit to jordanpowell88/platform that referenced this issue Nov 5, 2019
@jordanpowell88
refactor(example): add layout effect to listen for logoutConfirmation…
4a8e890 
… and dispatch closeSidenav

Closes ngrx#2186
brandonroberts pushed a commit that referenced this issue Nov 5, 2019
@jordanpowell88 @brandonroberts
refactor(example): close sidenav when logoutConfirmation is dispatched (
8a8dc83 
#2189)

Closes #2186
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this issue Nov 8, 2019
@jordanpowell88
Merge branch 'master' of https://github.com/ngrx/platform
c7a296f 
refactor(effects): refactor types in effects, expose metadata key for createEffect

refactor(example): close sidenav when logoutConfirmation is dispatched (ngrx#2189)

Closes ngrx#2186

docs: remove github link from navigation (ngrx#2188)

Closes ngrx#2185

feat(schematics): add message prompts for individual schematics (ngrx#2143)

test(store): fix flaky integration test (ngrx#2209)
jordanpowell88 added a commit to jordanpowell88/platform that referenced this issue Nov 14, 2019
@jordanpowell88
refactor(example): close sidenav when logoutConfirmation is dispatched (
4f1cbcf 
ngrx#2189)

Closes ngrx#2186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs Good First Issue Good issue for first-time contributor Project: Example App
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref(example): close Sidenav when logoutConfirmation is dispatched jordanpowell88/platform
1 participant
@brandonroberts