Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): add USER_RUNTIME_CHECKS public token #2006

Merged
merged 1 commit into from
Jul 13, 2019

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Only way to provide runtime checks is via store.forRoot()

Closes #1973

What is the new behavior?

Make it possible to define runtime checks via an injection token:

providers: [
  {
    provide: USER_RUNTIME_CHECKS,
    useValue: {
      strictStateImmutability: true,
      strictActionImmutability: true,
      strictStateSerializability: true,
      strictActionSerializability: true,
    },
  },
],

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@brandonroberts brandonroberts merged commit fa8da34 into master Jul 13, 2019
@brandonroberts brandonroberts deleted the pr/runtime-checks-provider branch July 13, 2019 18:07
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USER_RUNTIME_CHECKS public injection token
2 participants