Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USER_RUNTIME_CHECKS public injection token #1973

Closed
laurentgoudet opened this issue Jun 25, 2019 · 0 comments · Fixed by #2006
Closed

USER_RUNTIME_CHECKS public injection token #1973

laurentgoudet opened this issue Jun 25, 2019 · 0 comments · Fixed by #2006
Labels
Project: Store

Comments

@laurentgoudet
Copy link
Contributor

laurentgoudet commented Jun 25, 2019 •
edited
Loading

Providing configuration through an injection token vs. a forRoot object allows to more easily (cleanly) configure the StoreModule, especially when it's wrapped into another NgModule itself being imported by an application.

Meta reducers can be provided through USER_PROVIDED_META_REDUCERS, but for some reason _USER_RUNTIME_CHECKS is flagged as internal. If it was renamed to USER_RUNTIME_CHECKS & re-exported from @ngrx/store, it could be used to inject a runtime checks config.

If accepted, I would be willing to submit a PR for this feature

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Project: Store
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(store): add USER_RUNTIME_CHECKS public token ngrx/platform
2 participants
@laurentgoudet @timdeschryver