Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematics: deprecated usage of Type<T> or InjectionToken<T> #1968

Closed
timdeschryver opened this issue Jun 23, 2019 · 2 comments · Fixed by #1969 or TypescriptID/platform#235
Closed
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Project: Schematics

Comments

@timdeschryver
Copy link
Member

The schematics are currently generating deprecated versions of TestBed.get

deprecated from v8.0.0 use Type<T> or InjectionToken<T> This does not use the 
deprecated jsdoc tag on purpose because it renders all overloads as deprecated in
TSLint due to https://github.com/palantir/tslint/issues/4522.

Other information:

For example:

TestBed.get(CustomersEffects);

Should become:

TestBed.get<CustomersEffects>(CustomersEffects);

If accepted, I would be willing to submit a PR for this feature

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

@itayod
Copy link
Contributor

itayod commented Jun 23, 2019

@timdeschryver may I take this?

@brandonroberts brandonroberts added the community watch Someone from the community is working this issue/PR label Jun 23, 2019
@brandonroberts
Copy link
Member

It's yours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Project: Schematics
Projects
None yet
3 participants