Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store: add migration to move users off ngrx-store-freeze #1896

Closed
brandonroberts opened this issue May 28, 2019 · 5 comments · Fixed by #1901
Closed

Store: add migration to move users off ngrx-store-freeze #1896

brandonroberts opened this issue May 28, 2019 · 5 comments · Fixed by #1901
Assignees
@timdeschryver
Labels
enhancement Project: Store

Comments

@brandonroberts
Copy link
Member

The majority of our users are probably using ngrx-store-freeze to guard against state mutations. We have built-in run-time checks in version 8 to guard against those. This migration would

  • Check to see if they are using ngrx-store-freeze
    • Remove ngrx-store-freeze from imports and the meta-reducers array
    • Remove ngrx-store-freeze from their package.json dependencies.
  • Update StoreModule.forRoot() to enable the strictStateImmutability and strictActionImmutability run-time checks.
@santoshyadavdev
Copy link
Contributor

Hi @brandonroberts ,
Taking this next.

@brandonroberts
Copy link
Member Author

@santoshyadav198613 hold off on doing anything with this one yet

@santoshyadavdev
Copy link
Contributor

Cool, let me know once we want to proceed.

@timdeschryver timdeschryver self-assigned this May 30, 2019
@timdeschryver
Copy link
Member

We discussed this internally and I already started to work on this feature in #1901. I'm sorry @santoshyadav198613.

@timdeschryver timdeschryver mentioned this issue May 30, 2019
Merged
5 tasks
@santoshyadavdev
Copy link
Contributor

We discussed this internally and I already started to work on this feature in #1901. I'm sorry @santoshyadav198613.

No problem.

brandonroberts pushed a commit that referenced this issue Jun 3, 2019
@timdeschryver @brandonroberts
feat(store): add ngrx-store-freeze migration (#1901)
4146650 
Closes #1896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timdeschryver timdeschryver

Labels
enhancement Project: Store
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(store): add ngrx-store-freeze migration ngrx/platform
3 participants
@brandonroberts @santoshyadavdev @timdeschryver