Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematics: Add schematics for effect creators #1682

Closed
brandonroberts opened this issue Apr 1, 2019 · 7 comments · Fixed by #1725
Closed

Schematics: Add schematics for effect creators #1682

brandonroberts opened this issue Apr 1, 2019 · 7 comments · Fixed by #1725
Labels
Accepting PRs community watch Someone from the community is working this issue/PR enhancement Project: Schematics

Comments

@brandonroberts
Copy link
Member

Follow up to #1667

  1. Adds an effectCreators option to the effect, and feature schematics that uses the new effect creator function instead of decorators
  2. The effectCreators flag will use a different set of files for scaffolding. This keeps our current structure with files intact.
  3. Adds tests to verify the behavior of the previously mentioned schematics
@itayod
Copy link
Contributor

itayod commented Apr 6, 2019

hi @brandonroberts ,
I can start with this.

@timdeschryver timdeschryver added the community watch Someone from the community is working this issue/PR label Apr 6, 2019
@brandonroberts
Copy link
Member Author

👍🏿

@itayod
Copy link
Contributor

itayod commented Apr 10, 2019

@brandonroberts
by "use a different set of files" you mean just the template ?

@timdeschryver
Copy link
Member

I'm not Brandon, but yes these will be different templates.

@brandonroberts
Copy link
Member Author

Different set of files. I have a WIP branch here for action creators https://github.com/ngrx/platform/compare/schematics-action-creators?expand=1

@itayod
Copy link
Contributor

itayod commented Apr 10, 2019

Thanks @brandonroberts and @timdeschryver
I actually done about the same thing in my wip branch :)

but I think this solution might be an overkill for the effect case.
since most of the content in the effect file is not the method of creating effect, most of the template will be similar.

anyway, so I if you'r ok with the solution I will write the UT for it and upload the PR 😄

@brandonroberts
Copy link
Member Author

I agree in the effects case that its reasonable to keep it in the same template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepting PRs community watch Someone from the community is working this issue/PR enhancement Project: Schematics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants