Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schematics-Store: lastIndexOf #1659

Closed
WuglyakBolgoink opened this issue Mar 29, 2019 · 0 comments · Fixed by #1666
Closed

Schematics-Store: lastIndexOf #1659

WuglyakBolgoink opened this issue Mar 29, 2019 · 0 comments · Fixed by #1666
Labels
Accepting PRs bug Project: Schematics

Comments

@WuglyakBolgoink
Copy link

I try to check result and forgot write a store name:

$ ng g store -m modules/root-store -d

Result:

Cannot read property 'lastIndexOf' of undefined

image

there is no check if options.path exist
@WuglyakBolgoink WuglyakBolgoink changed the title Schematics: lastIndexOf Schematics-Store: lastIndexOf Mar 29, 2019
EnricoVogt added a commit to EnricoVogt/platform that referenced this issue Mar 29, 2019
@EnricoVogt
fix(schematics): avoid lastIndexOf error while creating store schemat…
199a251 
…ics (ngrx#1659)
EnricoVogt added a commit to EnricoVogt/platform that referenced this issue Mar 29, 2019
@EnricoVogt
fix(schematics): avoid lastIndexOf error while creating store schemat…
3d06428 
…ics (ngrx#1659)
@EnricoVogt EnricoVogt mentioned this issue Mar 29, 2019
Merged
3 tasks
EnricoVogt added a commit to EnricoVogt/platform that referenced this issue Mar 31, 2019
@EnricoVogt
fix(schematics): avoid lastIndexOf error while creating store schemat…
1f251ad 
…ics (ngrx#1659)
EnricoVogt added a commit to EnricoVogt/platform that referenced this issue Apr 1, 2019
@EnricoVogt
fix(schematics): avoid lastIndexOf error while creating store schemat…
1a70cc3 
…ics (ngrx#1659)
brandonroberts pushed a commit that referenced this issue Apr 3, 2019
@EnricoVogt @brandonroberts
fix(schematics): check for empty name when using store schematic for …
3b9b890 
…feature states (#1659) (#1666)

Closes #1659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs bug Project: Schematics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(schematics): avoid lastIndexOf error while creating store schematics (#1659) EnricoVogt/platform
2 participants
@brandonroberts @WuglyakBolgoink