Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example: Update app name for devtools #1270

Closed
brandonroberts opened this issue Aug 22, 2018 · 6 comments · Fixed by #1275
Closed

Example: Update app name for devtools #1270

brandonroberts opened this issue Aug 22, 2018 · 6 comments · Fixed by #1275
Labels
Accepting PRs Good First Issue Good issue for first-time contributor Project: Example App

Comments

@brandonroberts
Copy link
Member

Describe any alternatives/workarounds you're currently using

Other information:

If accepted, I would be willing to submit a PR for this feature

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[x] No

Rename NgRx Book Store Devtools to NgRx Book Store App or something easier to pick out of the list.
@koumatsumoto
Copy link
Contributor

I'll submit a pull reqest 😄

@koumatsumoto koumatsumoto mentioned this issue Aug 22, 2018
Merged
3 tasks
@brandonroberts
Copy link
Member Author

You're not a first-timer 😂

@MatsumotoKou
Copy link

sorry, I missed Good First Issue label 😣

@brandonroberts
Copy link
Member Author

No problem 👍

@timdeschryver
Copy link
Member

Don't force him to create a new account 😄

@brandonroberts
Copy link
Member Author

Burner GitHub accounts 😂

timdeschryver pushed a commit that referenced this issue Aug 22, 2018
@koumatsumoto @timdeschryver
refactor(example): rename devtools app name (#1275)
2268fc4 
closes #1270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs Good First Issue Good issue for first-time contributor Project: Example App
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(example): rename app name for devtools koumatsumoto/platform
4 participants
@brandonroberts @koumatsumoto @timdeschryver @MatsumotoKou