ci: build docs with node v10.12

ngrx · Nov 12, 2019 · db0e4d1 · db0e4d1
1 parent 77040f5
commit db0e4d1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -17,10 +17,16 @@ var_2: &run_in_node
 var_3: &set_bazel_options
   run:
     command: sudo cp .circleci/bazel.rc /etc/bazel.bazelrc
-var_4: &docs_cache_key yarn-docs-cache-{{ checksum "~/docs/projects/ngrx.io/yarn.lock" }}-0.1
+var_4: &docs_cache_key yarn-docs-cache-{{ checksum "~/docs/projects/ngrx.io/yarn.lock" }}-0.1.1
 var_5: &run_in_browser
   docker:
     - image: circleci/node:12.9.1-browsers
+var_6: &docs_in_node
+  docker:
+    - image: circleci/node:10.12
+var_7: &docs_in_browser
+  docker:
+    - image: circleci/node:10.12-browsers
 
 jobs:
   install:
@@ -115,7 +121,7 @@ jobs:
       - run: yarn run example:cypress:ci
 
   docs-tests:
-    <<: *run_in_browser
+    <<: *docs_in_browser
     working_directory: ~/docs/projects/ngrx.io
     steps:
       - checkout:
@@ -125,7 +131,7 @@ jobs:
       - run: yarn test --watch=false
 
   docs:
-    <<: *run_in_node
+    <<: *docs_in_node
     working_directory: ~/docs/projects/ngrx.io
     steps:
       - checkout:
@@ -166,7 +172,7 @@ jobs:
             echo 'export SHORT_GIT_HASH=$(git rev-parse --short $CIRCLE_SHA1)' >> $BASH_ENV
             echo 'export CIRCLE_PULL_REQUEST_NUMBER=$(echo "$CIRCLE_PULL_REQUEST" | cut -d"/" -f7)' >> $BASH_ENV
             source $BASH_ENV
-      - run: npm rebuild node-sass
+      # - run: npm rebuild node-sass
       - run: yarn build-for next --progress false --base-href /pr$CIRCLE_PULL_REQUEST_NUMBER-$SHORT_GIT_HASH/ --output-path dist/ngrx.io/pr$CIRCLE_PULL_REQUEST_NUMBER-$SHORT_GIT_HASH/ && yarn copy-404-page
       - run: cp -rf src/extra-files/next/. dist/ngrx.io/pr$CIRCLE_PULL_REQUEST_NUMBER-$SHORT_GIT_HASH/
       - run: yarn --cwd ../../ install && yarn --cwd ../../ run deploy:preview
@@ -176,7 +182,7 @@ jobs:
             - ~/docs/projects/ngrx.io/node_modules
 
   deploy-docs-stable:
-    <<: *run_in_node
+    <<: *docs_in_node
     working_directory: ~/docs/projects/ngrx.io
     steps:
       - checkout:

diff --git a/projects/ngrx.io/package.json b/projects/ngrx.io/package.json
@@ -69,7 +69,7 @@
     "copy-404-page": "node scripts/copy-404-page"
   },
   "engines": {
-    "node": ">=10.9.0 <=11.12.0",
+    "node": ">=10.9.0 <=12.12.0",
     "npm": ">=5.3.0",
     "yarn": ">=1.9.2 <2.0.0"
   },