perf(signals): avoid creating unnecessary objects in excludeKeys (#4240)

Co-authored-by: Tomasz Ducin <[email protected]>
ngrx · Feb 12, 2024 · b90da9d · b90da9d
1 parent 1975af6
commit b90da9d
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/modules/signals/src/helpers.ts b/modules/signals/src/helpers.ts
@@ -2,8 +2,10 @@ export function excludeKeys<
   Obj extends Record<string, unknown>,
   Keys extends string[]
 >(obj: Obj, keys: Keys): Omit<Obj, Keys[number]> {
-  return Object.keys(obj).reduce(
-    (acc, key) => (keys.includes(key) ? acc : { ...acc, [key]: obj[key] }),
-    {}
-  ) as Omit<Obj, Keys[number]>;
+  return Object.keys(obj).reduce<Record<string, unknown>>((acc, key) => {
+    if (!keys.includes(key)) {
+      acc[key] = obj[key];
+    }
+    return acc;
+  }, {}) as Omit<Obj, Keys[number]>;
 }