fix(eslint-plugin): ignore select name within createFeature (#3788)

Closes #3786
ngrx · Mar 1, 2023 · b58f9a3 · b58f9a3
1 parent 6d615b3
commit b58f9a3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/modules/eslint-plugin/spec/rules/prefix-selectors-with-select.spec.ts b/modules/eslint-plugin/spec/rules/prefix-selectors-with-select.spec.ts
@@ -25,6 +25,15 @@ const valid: () => RunTests['valid'] = () => [
   `export const select_feature = createSelectorFactory(factoryFn)`,
   `export const select$feature = createSelectorFactory(factoryFn)`,
   `export const selectF01 = createSelector(factoryFn)`,
+  `
+    export const authFeature = createFeature({
+      name: 'auth',
+      reducer: authReducer,
+      extraSelectors: ({selectToken}) => ({
+        selectIsAuthorized: createSelector(selectToken, token => !!token)
+      }),
+    })
+  `,
 ];
 
 const invalid: () => RunTests['invalid'] = () => [

diff --git a/modules/eslint-plugin/src/rules/store/prefix-selectors-with-select.ts b/modules/eslint-plugin/src/rules/store/prefix-selectors-with-select.ts
@@ -34,7 +34,7 @@ export default createRule<Options, MessageIds>({
   defaultOptions: [],
   create: (context) => {
     return {
-      'VariableDeclarator[id.name!=/^select[^a-z].+$/]:matches([id.typeAnnotation.typeAnnotation.typeName.name=/^MemoizedSelector(WithProps)?$/], :has(CallExpression[callee.name=/^(create(Feature)?Selector|createSelectorFactory)$/]))'({
+      'VariableDeclarator[id.name!=/^select[^a-z].+$/]:not(:has(Identifier[name="createFeature"])):matches([id.typeAnnotation.typeAnnotation.typeName.name=/^MemoizedSelector(WithProps)?$/], :has(CallExpression[callee.name=/^(create(Feature)?Selector|createSelectorFactory)$/]))'({
         id,
       }: TSESTree.VariableDeclarator & { id: TSESTree.Identifier }) {
         const suggestedName = getSuggestedName(id.name);