#405 selectId as optional

ngrx · Sep 19, 2017 · 5249ac5 · 5249ac5
1 parent 3219623
commit 5249ac5
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/modules/entity/src/create_adapter.ts b/modules/entity/src/create_adapter.ts
@@ -10,14 +10,15 @@ import { createSelectorsFactory } from './state_selectors';
 import { createSortedStateAdapter } from './sorted_state_adapter';
 import { createUnsortedStateAdapter } from './unsorted_state_adapter';
 
-export function createEntityAdapter<T>(options?: {
-  selectId: IdSelector<T>;
-  sortComparer?: false | Comparer<T>;
-}): EntityAdapter<T> {
-  options = options || { selectId: (instance: any) => instance.id };
-
+export function createEntityAdapter<T>(
+  options: {
+    selectId?: IdSelector<T>;
+    sortComparer?: false | Comparer<T>;
+  } = {}
+): EntityAdapter<T> {
   const { selectId, sortComparer }: EntityDefinition<T> = {
     sortComparer: false,
+    selectId: (instance: any) => instance.id,
     ...options,
   };