compact: remove cancel on SyncMetas errors (thanos-io#5923)

in a favour of 86b4039 SyncMetas will retry if it's retriable. Also, the cleanPartialMarked calls are surrounded by runutil.Repeat() will be repeated, the ones not and are not retriable will throw an interrupt to run.Group() by returning err and Group will call cancel() as it's configured for its interrupt func. Signed-off-by: Seena Fallah <[email protected]> Signed-off-by: Seena Fallah <[email protected]>
ngraham20 · May 18, 2023 · 28d5482 · 28d5482
1 parent e22ccf7
commit 28d5482
Showing 1 changed file with 0 additions and 1 deletion.
diff --git a/cmd/thanos/compact.go b/cmd/thanos/compact.go
@@ -406,7 +406,6 @@ func runCompact(
 		defer cleanMtx.Unlock()
 
 		if err := sy.SyncMetas(ctx); err != nil {
-			cancel()
 			return errors.Wrap(err, "syncing metas")
 		}