Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consume variables to set username and password otherwise use defaults #90

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

paklids
Copy link
Contributor

@paklids paklids commented Aug 20, 2021

This should resolve the request for using env vars to set the username and password of the UI.

If the env var does not exist or has a zero value then it should fall back to defaults.

Note: must disable persistent /data volume to test this one thoroughly

Copy link
Owner

@ngoduykhanh ngoduykhanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @paklids .

@ngoduykhanh ngoduykhanh merged commit acbe5b4 into ngoduykhanh:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants