Expand env vars and flags #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoduykhanh
requested changes
Aug 28, 2021
main.go
Outdated
Comment on lines
131
to
158
| func LookupEnvOrString(key string, defaultVal string) string { | ||
| if val, ok := os.LookupEnv(key); ok { | ||
| return val | ||
| } | ||
| return defaultVal | ||
| } | ||
|
|
||
| func LookupEnvOrBool(key string, defaultVal bool) bool { | ||
| if val, ok := os.LookupEnv(key); ok { | ||
| v, err := strconv.ParseBool(val) | ||
| if err != nil { | ||
| fmt.Fprintf(os.Stderr, "LookupEnvOrInt[%s]: %v\n", key, err) | ||
| } | ||
| return v | ||
| } | ||
| return defaultVal | ||
| } | ||
|
|
||
| func LookupEnvOrInt(key string, defaultVal int) int { | ||
| if val, ok := os.LookupEnv(key); ok { | ||
| v, err := strconv.Atoi(val) | ||
| if err != nil { | ||
| fmt.Fprintf(os.Stderr, "LookupEnvOrInt[%s]: %v\n", key, err) | ||
| } | ||
| return v | ||
| } | ||
| return defaultVal | ||
| } |
There was a problem hiding this comment.
Can you move these functions to util/util.go?
There was a problem hiding this comment.
Yes. I can. But I think it would be better if you reject this PR, and I rewrote it using the viper library. https://github.com/spf13/viper
What do you think?
There was a problem hiding this comment.
hmm, I don't know. To me, it looks like using viper is an overkill solution for this purpose. I would prefer simple ones.
There was a problem hiding this comment.
No problem. Lets stick to the original plan. I'll move the functions to util.
There was a problem hiding this comment.
Changes made and smoke tested. If I werent so lazy, I would write some real tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to be able to set configurations from environment vars or flags. This should allow more flexibility in the future.