Replace go.rice with native go embedding #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bytedream sorry for my late review. Great to know that we don't need Go rice anymore for this purpose. I merged some older PRs which created the merge conflicts. Can you update your branch? |
# Conflicts: # Dockerfile # handler/routes.go # main.go # router/router.go # util/util.go
|
@ngoduykhanh I've merged the master branch/resolved the conflicts 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the go.rice tool with native go embedding which is available since go1.16 and eliminates the requirement of the go.rice cli tool to generate code. It also eliminates #274 which happened multiple times while testing with go.rice.
The logic is nearly the same as with go.rice besides the type changes.
This also bumps the minimal required go version from 1.14 to 1.16.