Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n-ptBR): 🔥 add support for last name generation with locale #372

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

kabrunko-dev
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe: add more locale data for pt-BR (brazilian portuguese)

What is the current behavior?

  • Issue Number: N/A

What is the new behavior?

Augment randLastName() to use locale data passed as argument from FakeOptions interface.

Does this PR introduce a breaking change?

  • Yes
  • No

Copy link

stackblitz bot commented Dec 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NetanelBasal NetanelBasal merged commit 37cdf01 into ngneat:main Dec 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants