Remove field name decapitalization in the scheme #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
For consistency with DataFabric examples, we make field names start with lowercase letter. As a result, we convert the first character of field name in a go struct to lowercase. For example, MyField -> myField. However, the generated scheme names for fields like HTTPRoutes look a bit ugly: HTTPRoutes -> hTTPRoutes
Solution:
Because it is not a hard requirement for Avro scheme, we can use names like HTTPRoutes just fine.
long? HTTPRoutes = null;
CLOSES -- #33
Note:
The alternative here is to support go tags like
So that in the generated scheme, it will be:
However, that would lead to +173 lines of code (I originally went with that approach)
Checklist
Before creating a PR, run through this checklist and mark each as complete.
guide