-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support AWS S3 Express One Zone buckets #229
Merged
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3855e86
docs: include instructions for usage with AWS S3 One Zone
4141done 41fe06a
fix typo
4141done 0424425
fix typo
4141done 16a2fea
move back to not including bucket in s3 address for express zone
4141done cdd150d
experimental refactor to normalize bucket naming needs
4141done 05ba58b
docs, add s3_style config
4141done fee3ef0
fix tests for bucket prepended hostname
4141done ce773b6
move to using as the path style
4141done 1d10989
add matrix to maintain coverage for both path styles
4141done de7cb16
fix some omissions
4141done 2d8b6a0
default to s3 as a service type if variable not provided
4141done 437cc07
fix readme
4141done File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
terraform 1.8.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
# Purpose | ||
This Terraform script sets up an AWS S3 Express One Zone bucket for testing. | ||
|
||
## Usage | ||
Use environment variables to authenticate: | ||
|
||
```bash | ||
export AWS_ACCESS_KEY_ID="anaccesskey" | ||
export AWS_SECRET_ACCESS_KEY="asecretkey" | ||
export AWS_REGION="us-west-2" | ||
``` | ||
|
||
Generate a plan: | ||
```bash | ||
terraform plan -out=plan.tfplan \ | ||
> -var="bucket_name=my-bucket-name--usw2-az1--x-s3" \ | ||
> -var="region=us-west-2" \ | ||
> -var="availability_zone_id=usw2-az1" \ | ||
> -var="[email protected]" | ||
``` | ||
> [!NOTE] | ||
> Note that AWS S3 Express One Zone is only available in [certain regions and availability zones](https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-express-networking.html#s3-express-endpoints). If you get an error like this: `api error InvalidBucketName`. If you have met the [naming rules](https://docs.aws.amazon.com/AmazonS3/latest/userguide/directory-bucket-naming-rules.html), this likely means you have chosen a bad region/availability zone combination. | ||
|
||
If you are comfortable with the plan, apply it: | ||
``` | ||
terraform apply "plan.tfplan" | ||
``` | ||
|
||
Then build the image (you can also use the latest release) | ||
```bash | ||
docker build --file Dockerfile.oss --tag nginx-s3-gateway:oss --tag nginx-s3-gateway . | ||
``` | ||
|
||
Configure and run the image: | ||
|
||
```bash | ||
docker run --rm --env-file ./settings.s3express.example --publish 80:80 --name nginx-s3-gateway \ | ||
nginx-s3-gateway:oss | ||
``` | ||
|
||
Confirm that it is working. The terraform script will prepopulate the bucket with a single test object | ||
```bash | ||
curl http://localhost:80/test.txt | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
provider "aws" { | ||
region = var.region | ||
} | ||
|
||
resource "aws_s3_directory_bucket" "example" { | ||
bucket = var.bucket_name | ||
location { | ||
name = var.availability_zone_id | ||
} | ||
|
||
force_destroy = true | ||
} | ||
|
||
data "aws_partition" "current" {} | ||
data "aws_caller_identity" "current" {} | ||
|
||
data "aws_iam_policy_document" "example" { | ||
statement { | ||
effect = "Allow" | ||
|
||
actions = [ | ||
"s3express:*", | ||
] | ||
|
||
resources = [ | ||
aws_s3_directory_bucket.example.arn, | ||
] | ||
|
||
principals { | ||
type = "AWS" | ||
identifiers = ["arn:${data.aws_partition.current.partition}:iam::${data.aws_caller_identity.current.account_id}:root"] | ||
} | ||
} | ||
} | ||
|
||
resource "aws_s3_bucket_policy" "example" { | ||
bucket = aws_s3_directory_bucket.example.bucket | ||
policy = data.aws_iam_policy_document.example.json | ||
} | ||
|
||
# The filemd5() function is available in Terraform 0.11.12 and later | ||
# For Terraform 0.11.11 and earlier, use the md5() function and the file() function: | ||
# etag = "${md5(file("path/to/file"))}" | ||
# etag = filemd5("path/to/file") | ||
resource "aws_s3_object" "example" { | ||
bucket = aws_s3_directory_bucket.example.bucket | ||
key = "test.txt" | ||
source = "${path.root}/test_data/test.txt" | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
S3_BUCKET_NAME=my-bucket-name--usw2-az1--x-s3 | ||
AWS_ACCESS_KEY_ID=ZZZZZZZZZZZZZZZZZZZZ | ||
AWS_SECRET_ACCESS_KEY=aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa | ||
AWS_SESSION_TOKEN=bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb | ||
S3_SERVER=s3express-usw2-az1.us-west-2.amazonaws.com | ||
S3_SERVER_PORT=443 | ||
S3_SERVER_PROTO=https | ||
S3_REGION=us-west-2 | ||
S3_STYLE=virtual | ||
S3_SERVICE=s3express | ||
DEBUG=true | ||
AWS_SIGS_VERSION=4 | ||
ALLOW_DIRECTORY_LIST=false | ||
PROVIDE_INDEX_PAGE=false | ||
APPEND_SLASH_FOR_POSSIBLE_DIRECTORY=false | ||
DIRECTORY_LISTING_PATH_PREFIX="" | ||
PROXY_CACHE_MAX_SIZE=10g | ||
PROXY_CACHE_SLICE_SIZE="1m" | ||
PROXY_CACHE_INACTIVE=60m | ||
PROXY_CACHE_VALID_OK=1h | ||
PROXY_CACHE_VALID_NOTFOUND=1m | ||
PROXY_CACHE_VALID_FORBIDDEN=30s |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Congratulations, friend. You are using Amazon S3 Express One Zone. | ||
🚂🚂🚂 Choo-choo~ 🚂🚂🚂 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# Format for bucket name [bucket_name]--[azid]--x-s3 | ||
variable "bucket_name" { | ||
type = string | ||
default = "example--usw2-az2--x-s3" | ||
} | ||
|
||
variable "owner_email" { | ||
type = string | ||
} | ||
|
||
variable "region" { | ||
type = string | ||
default = "us-west-2" | ||
} | ||
|
||
# "https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html#az-ids" | ||
variable "availability_zone_id" { | ||
type = string | ||
default = "usw2-az2" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
terraform { | ||
required_providers { | ||
aws = { | ||
source = "hashicorp/aws" | ||
version = "5.45.0" | ||
} | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Annotation:
This is the primary change. We determine this value in the startup script then template it in before NGINX starts. While before this value was calculated in three different places, using
js_var
allows access to its value both in the njs script and in the configuration.