[Je issue/164 #169
Closed
[Je issue/164 #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4141done
commented
Aug 18, 2023
| if (len < 1) { | ||
| return false; | ||
| } | ||
| if (!path) return false; |
There was a problem hiding this comment.
Annotation:
Not a big deal, but the previous implementation didn't account for null. Perhaps that was on purpose? Either way, if we assume null, undefined, or "" are all "not a directory" this function gets a lot simpler.
4141done
commented
Aug 18, 2023
| @@ -326,7 +326,7 @@ server { | |||
|
|
|||
| location @trailslash { | |||
| # 302 to request without slashes | |||
| rewrite ^ $scheme://$http_host$request_uri/ redirect; | |||
| rewrite ^ $scheme://$http_host$uri/$is_args$query_string redirect; | |||
There was a problem hiding this comment.
Annotation:
Insert the trailing slash after the path and preserve the query string after it.
This was referenced Aug 18, 2023
Merged
|
Closing in favor of #167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR presents some additional ideas to be considered for addition to #167 aiming to fix issue #164
Expectations
This solution assumes that the following configuration options are set to true
APPEND_SLASH_FOR_POSSIBLE_DIRECTORYPROVIDE_INDEX_PAGEALLOW_DIRECTORY_LISTGiven a folder
testwith anindex.htmlpresent in the directory, theindex.htmlshould be served for:/test/test//test?foo=bar/test/?foo=barGiven a folder
testWITHOUT anindex.htmlpresent in the directory, files in the directory should be listed for:/test/test//test?foo=bar/test/?foo=barNotes
@trailslashwas rewriting to$request_uriwith a trailing slash on the end. In the case of/test?foo=barwe'd wind up with/test?foo=bar/which when combined with the other changes led to a rewrite loop