Fix error messages for missing dependencies, allow test suite to run on MacOS by supporting md5
#162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elJosho
pushed a commit
to elJosho/nginx-s3-gateway
that referenced
this pull request
Oct 25, 2023
… on MacOS by supporting `md5` (nginxinc#162) # What Fix error messages for missing dependencies, allow test suite to run on MacOS by supporting `md5` ## Dependency Checks There were some checks like this: ```bash curl_cmd="$(command -v curl)" if ! [ -x "${curl_cmd}" ]; then e "required dependency not found: curl not found in the path or not executable" exit ${no_dep_exit_code} fi ``` However, `command -v` exits with an error if the command does not exist. This results in the nice error message not being shown. The solution is to avoid the assignment of the variable erroring and instead relying on the executability check to make sure we have the right thing ## `md5` compatibility The test script depends on `md5sum` which is not available on MacOS. Thus, tests would fail at the start when run on MacOS. MacOS has a tool called `md5`, which when called with the `-r` flag which reverses the format of the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix error messages for missing dependencies, allow test suite to run on MacOS by supporting
md5Dependency Checks
There were some checks like this:
However,
command -vexits with an error if the command does not exist. This results in the nice error message not being shown.The solution is to avoid the assignment of the variable erroring and instead relying on the executability check to make sure we have the right thing
md5compatibilityThe test script depends on
md5sumwhich is not available on MacOS. Thus, tests would fail at the start when run on MacOS.MacOS has a tool called
md5, which when called with the-rflag which reverses the format of the output.