Skip to content
This repository has been archived by the owner on May 24, 2023. It is now read-only.

Make linter happy again #71

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Make linter happy again #71

merged 2 commits into from
Aug 26, 2022

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Aug 26, 2022

Proposed changes

  • Update Go v1.19
  • Fix liner complains (change of Go std libraries)
  • Remove not supported liner checks
  • Run some tests in parallel

Test run:

➜  nginx-ns1-gslb git:(fix-library-dependency) make test
go test ./... -race -shuffle=on
?   	github.com/nginxinc/nginx-ns1-gslb/cmd/agent	[no test files]
?   	github.com/nginxinc/nginx-ns1-gslb/internal	[no test files]
ok  	github.com/nginxinc/nginx-ns1-gslb/internal/agent	0.740s
ok  	github.com/nginxinc/nginx-ns1-gslb/internal/input	0.392s
ok  	github.com/nginxinc/nginx-ns1-gslb/internal/output	0.559s

Linter:

➜  nginx-ns1-gslb git:(fix-library-dependency) make lint
docker run --pull always --rm -v /Users/j.jarosz/work/nginx-ns1-gslb:/nginx-ns1-gslb -w /nginx-ns1-gslb -v /Users/j.jarosz/Library/Caches/go-build:/cache/go -e GOCACHE=/cache/go -e GOLANGCI_LINT_CACHE=/cache/go -v /Users/j.jarosz/go/pkg:/go/pkg golangci/golangci-lint:latest golangci-lint --color always run
latest: Pulling from golangci/golangci-lint
Digest: sha256:af723bd6fb13b3cf2dc6e39b5fbc9a6bd0ada2c6f92ce3590eeb0ce71d9174d4
Status: Image is up to date for golangci/golangci-lint:latest

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx added the tests Pull requests that update tests label Aug 26, 2022
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Aug 26, 2022
@jjngx jjngx merged commit ce19f61 into main Aug 26, 2022
@jjngx jjngx deleted the fix-library-dependency branch August 26, 2022 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants