This repository has been archived by the owner on May 24, 2023. It is now read-only.
Add supporting documents to ns1 agent #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rulox
suggested changes
Sep 18, 2019
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
| Provide the following files as part of the bug report | ||
|
|
||
| * NGINX Plus configuration. Run `sudo nginx -T` to gather the full configuration | ||
| * nginx-ns1-gslb configuration from `/etc/nginx/config.yaml` |
There was a problem hiding this comment.
Suggested change
| * nginx-ns1-gslb configuration from `/etc/nginx/config.yaml` | |
| * nginx-ns1-gslb `yaml` configuration file. |
CONTRIBUTING.md
Outdated
| @@ -0,0 +1,70 @@ | |||
| # Contributing Guidelines | |||
|
|
|||
| The following is a set of guidelines for contributing to the NGINX AWS Auto-Scale Group Sync tool. We really appreciate that you are considering contributing! | |||
There was a problem hiding this comment.
Suggested change
| The following is a set of guidelines for contributing to the NGINX AWS Auto-Scale Group Sync tool. We really appreciate that you are considering contributing! | |
| The following is a set of guidelines for contributing to the NGINX Plus NS1 GLSB tool. We really appreciate that you are considering contributing! |
CONTRIBUTING.md
Outdated
|
|
||
| * nginx-ns1-gslb is a service written in Go that works with NGINX Plus. | ||
| * The main code is found under `/cmd/agent/` | ||
| * Tools for building the service for supported Operating Systems are found under `/build/package` |
There was a problem hiding this comment.
This line needs to be removed as we don't provide any packaging solution yet.
Dean-Coakley
suggested changes
Sep 18, 2019
There was a problem hiding this comment.
👍 on all @Rulox change requests
Please update the PR title to something more descriptive.
Perhaps something like:
Add supporting documentation expected of an OSS project
Adds contributing guide, issues template,...etc
ampant
changed the title
ampant
changed the title
Dean-Coakley
approved these changes
Sep 19, 2019
Rulox
approved these changes
Sep 19, 2019
Thanks |
Addressed changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.