Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 30 tcp http support #31

Merged
merged 12 commits into from
Apr 10, 2023
Merged

Issue 30 tcp http support #31

merged 12 commits into from
Apr 10, 2023

Conversation

ciroque
Copy link
Collaborator

@ciroque ciroque commented Mar 31, 2023

Proposed changes

This change introduces a layer between the Synchronizer and the Border Servers (NGINX Plus running outside the Cluster in our main use case). It further supports Annotations on the Service that determine if the Upstream to be updated is a Stream ("tcp"), or HTTP ("tcp") Upstream block.

The Annotations are key/value pairs on the Service itself, the key is the Port Name (and the Upstream name at this time), and the value is one of "tcp" or "http". A value other than these results in a NullBorderClient implementation being created (to avoid panics). An accompanying error indicates the problem. Check your errors...

"TCP" will update the Border Servers using the Update/DeleteStreamUpstreamServers methods on the NGINX Plus client.

"HTTP" will update the Border Servers using the Update/DeleteHttpUpstreamServer methods on the NGINX Plus client.

This implementation also provides a foundation on which other Border Servers can be created. **This is not a goal of the project at present.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@ciroque ciroque requested a review from chrisakker as a code owner March 31, 2023 22:39
@ciroque ciroque marked this pull request as draft March 31, 2023 22:41
@chrisakker
Copy link
Collaborator

I see an typo in the Proposed changes, paragraph 4:
"HTTP" will update the Border Servers using the Update/DeleteHttpServer methods on the NGINX Plus client.
Should be:
"HTTP" will update the Border Servers using the Update/DeleteHttpUpstreamServer methods on the NGINX Plus client.

@ciroque ciroque marked this pull request as ready for review April 10, 2023 17:10
@ciroque ciroque merged commit eedb6de into main Apr 10, 2023
@ciroque ciroque deleted the iss-30-tcp-http-support branch April 10, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants