fix: helm Chart erros + hard coding #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still hardcoding namespace because the application cannot use another namespaces . it resolves nginxinc#158
|
it solves #158 |
|
Hello @abdennour , Thanks for this contribution! I will take a run through this change tomorrow and complete my review. On the surface it looks good, just need to run it into a Cluster and ensure I understand it better. Thanks again! |
|
Hello @ciroque , thanks for quick & positive response to PR |
ciroque
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Hi @abdennour , I just ran this change into our test k8s cluster and everything looks good. Going to rebase and merge momentarily.
Thanks again for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still hardcoding namespace because the application cannot use another namespaces . it resolves #158
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.mdandCHANGELOG.md)