Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #15

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Improve test coverage #15

merged 1 commit into from
Mar 9, 2023

Conversation

ciroque
Copy link
Collaborator

@ciroque ciroque commented Mar 9, 2023

  • Move setting to the configuration
  • Adds tests for probation modules
  • Minor cleanups
  • Updates tests for the Watcher
  • Updates tests for the Handler
  • Furthering the settings refactor
  • Add Synchronizer tests
  • Warming up my refactoring muscles
  • Squash Here : More and Better tests

Proposed changes

Work to improve the repo for release as open source. Mostly focused on adding tests, plenty of refactoring is involved, make more use of interfaces, moving hard-coded values to configuration, and some inversion of control improvements.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

- Move setting to the configuration
- Adds tests for probation modules
- Minor cleanups
- Updates tests for the Watcher
- Updates tests for the Handler
- Furthering the settings refactor
- Add Synchronizer tests
- Warming up my refactoring muscles
- Squash Here : More and Better tests
@ciroque ciroque requested review from sdutta9 and chrisakker March 9, 2023 22:25
Copy link
Collaborator

@chrisakker chrisakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@chrisakker chrisakker merged commit e5a674b into main Mar 9, 2023
@ciroque ciroque deleted the updated-tests branch March 9, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants