SECURITY: Make the Certificates an unloggable type #145
Comments
4 tasks
4141done
added a commit
that referenced
this issue
Dec 15, 2023
…ing (#147) We save the values of the provided certs that we retrieve from Kubernetes secrets in the `Certificates` attribute on the `Certificates` struct. This is sensitive information that we want to make sure stays out of the logs and any stack traces. A common approach to this is to create a type definition for sensitive values that implements `Stringer` and `JSON` interfaces and cast the sensitive data to that value. Fixes issues #145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Leaking certs in logs is not acceptable. To help ensure this doesn't happen make the Certificates type (internal/certification/certificates.go) unloggable as described here: https://www.commonfate.io/blog/prevent-logging-secrets-in-go-by-using-custom-types
The text was updated successfully, but these errors were encountered: