Skip to content

Commit

Permalink
comment changes
Browse files Browse the repository at this point in the history
  • Loading branch information
4141done committed Dec 15, 2023
1 parent beea17c commit 3d3e17f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
5 changes: 0 additions & 5 deletions internal/certification/certificates.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,6 @@ const (
)

type Certificates struct {
// {
// ClientCertificateSecretKey: {
// "tls.crt": []byte
// }
// }
Certificates map[string]map[string]core.SecretBytes

// Context is the context used to control the application.
Expand Down
1 change: 0 additions & 1 deletion internal/configuration/settings.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ func (s *Settings) Initialize() error {

certificates := certification.NewCertificates(s.Context, s.K8sClient)

// q. Why is this a separate step?
err = certificates.Initialize()
if err != nil {
return fmt.Errorf(`error occurred initializing certificates: %w`, err)
Expand Down
6 changes: 6 additions & 0 deletions internal/core/secret_bytes.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ import (
"encoding/json"
)

// Wraps byte slices which potentially could contain
// sensitive data that should not be output to the logs.
// This will output [REDACTED] if attempts are made
// to print this type in logs, serialize to JSON, or
// otherwise convert it to a string.
// Usage: core.SecretBytes(myByteSlice)
type SecretBytes []byte

func (sb SecretBytes) String() string {
Expand Down

0 comments on commit 3d3e17f

Please sign in to comment.