Update validateBackendRef invalid group error conditions #800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The HTTPRouteInvalidBackendRefUnknownKind conformance test expects ResolvedRefs/False/InvalidKind condition to be set on the HTTPRoute if a BackendRef specifies an unknown kind.
Solution: We actually do set the correct condition in this case where just Kind is invalid but Group is valid, but when Group is invalid, we set a different condition. Solution is to update the condition reason to InvalidKind when either Kind or Group is invalid. Comment for context from @pleshakov:
Testing: The failing conformance test now passes successfully:
Closes #776
Checklist
Before creating a PR, run through this checklist and mark each as complete.