Add NewListenerInvalidRouteKinds condition #799
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The GatewayInvalidRouteKind conformance test expects the ResolvedRef/False/InvalidRouteKinds condition to be set on a Listener that specifies an invalid route kind.
Solution: Add a NewListenerInvalidRouteKinds condition which is used when a Listener specifies an invalid route kind
Testing: Ran the GatewayInvalidRouteKind conformance tests.
TestConformance/GatewayInvalidRouteKind/Gateway_listener_should_have_a_false_ResolvedRefs_condition_with_reason_InvalidRouteKinds_and_HTTPRoute_must_be_put_in_the_supportedKinds
is now passing.NOTE: This PR does not address both failing tests, only the correct condition, as we currently do not support setting the SupportedKinds based on the listener. This will be fixed in a separate PR. See #690
Closes #774
Checklist
Before creating a PR, run through this checklist and mark each as complete.