Add timeout and retry logic for finding NGINX PID file #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjberman
approved these changes
May 24, 2023
ciarams87
force-pushed
the
fix/dont-return-error-fnf
branch
from
cbf5e7b to
c4ed966
Compare
pleshakov
reviewed
May 25, 2023
ciarams87
force-pushed
the
fix/dont-return-error-fnf
branch
from
c4ed966 to
7bfaf36
Compare
ciarams87
force-pushed
the
fix/dont-return-error-fnf
branch
2 times, most recently
from
9231da3 to
5219023
Compare
sjberman
reviewed
Jun 8, 2023
ciarams87
force-pushed
the
fix/dont-return-error-fnf
branch
from
8f1c1df to
d1ee640
Compare
ciarams87
changed the title
ciarams87
force-pushed
the
fix/dont-return-error-fnf
branch
2 times, most recently
from
a9c6d3d to
3087bd4
Compare
pleshakov
suggested changes
Jun 8, 2023
ciarams87
force-pushed
the
fix/dont-return-error-fnf
branch
from
3087bd4 to
7d309c7
Compare
pleshakov
suggested changes
Jun 9, 2023
ciarams87
force-pushed
the
fix/dont-return-error-fnf
branch
from
7d309c7 to
97dfb91
Compare
ciarams87
force-pushed
the
fix/dont-return-error-fnf
branch
from
97dfb91 to
a864dc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Occasionally, the Gateway container starts before the NGINX container, and this means we may attempt a reload of NGINX before the NGINX process exists. This commit checks if the PID file exists with timeout and retry logic to give the NGINX container time to start.
Closes #600
Checklist
Before creating a PR, run through this checklist and mark each as complete.