Allow empty sectionName in HTTPRoute parentRef #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
pleshakov
suggested changes
May 8, 2023
Support for empty sectionName in HTTPRoute parentRef. This will bind the route to all listeners with matching hostnames. If multiple listeners match, we'll choose the most specific one (mainly for TLS case to ensure proper certs are used). Either way, we should end up with a single nginx server for the hostname. We could end up with duplicate match rules if multiple listeners match, but nginx/njs will send traffic properly. At some point we'll need to figure out how to de-dupe these.
sjberman
force-pushed
the
feature/empty-sectionname
branch
from
5e006a9 to
c9ae428
Compare
kate-osborn
requested changes
May 9, 2023
There was a problem hiding this comment.
@sjberman @pleshakov do you think this change warrants a new example?
To me it doesn't really feel like it needs it. Behaviorally, not much is really changing. It's more of removing a requirement. |
Fair enough. Can we just remove one of the sectionNames from an example so we can exercise this code when we manually test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for empty sectionName in HTTPRoute parentRef. This will bind the route to all listeners with matching hostnames.
If multiple listeners match, we'll choose the most specific one (mainly for TLS case to ensure proper certs are used). Either way, we should end up with a single nginx server for the hostname. We could end up with duplicate match rules if multiple listeners match, but nginx/njs will send traffic properly. At some point we'll need to figure out how to de-dupe these.
Closes #479