Implement NKG-specific field validation for HTTPRoutes #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce HTTPFieldsValidator interface for validating fields of HTTP-related Gateway API resources according to the data-plane specific rules. - Validate HTTPRoute resources when building the graph using data-plane agnostic rules. - Validate HTTPRoute resources when building the graph using HTTPFieldsValidator according to the data-plane rules. - Implement an HTTPFieldsValidator for NGINX-specific validation rules. Fixes #412
kate-osborn
requested changes
Mar 9, 2023
Co-authored-by: Kate Osborn <[email protected]>
Closed
pleshakov
force-pushed
the
feature/httproute-validation
branch
from
fe026d7 to
3b5a532
Compare
pleshakov
added a commit
that referenced
this pull request
Mar 23, 2023
The PR #455 brought NKG-specific validation for HTTPRoutes. The implementation uses https://pkg.go.dev/k8s.io/apimachinery/pkg/util/validation/field to generate validation errors. This commit makes generated Gateway-related errors consistent with HTTPRoute-related errors by starting using that package above. Fixes #473
pleshakov
added a commit
that referenced
this pull request
Mar 23, 2023
The PR #455 brought NKG-specific validation for HTTPRoutes. The implementation uses https://pkg.go.dev/k8s.io/apimachinery/pkg/util/validation/field to generate validation errors. This commit makes generated Gateway-related errors consistent with HTTPRoute-related errors by starting using that package above. Fixes #473
pleshakov
changed the title
This was referenced Aug 19, 2024
Update module github.com/nginxinc/nginx-gateway-fabric to v0.6.0
lucacome/nginx-kubernetes-gateway#9
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #412
Note: the validation uses https://pkg.go.dev/k8s.io/apimachinery/pkg/util/validation/field to generate validation errors. This package generates descriptive messages that can pinpoint specific problematic field. Additionally, such messages would be consistent with the the webhook or Kubernetes API server errors. It will make sense to update #407 after this PR is merged to also use that package.