Fix initContainer failure during pod restart

[pl4nty]

Proposed changes

The gateway initContainer fails when creating folders on the config volume, if they already exist:

mkdir: can't create directory '/etc/nginx/conf.d': File exists
mkdir: can't create directory '/etc/nginx/secrets': File exists

This failure prevents the gateway from starting. This PR adds a mkdir flag to ignore the error and skip folder creation if the folders already exist.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto main
• I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

[pl4nty]

This fix resolved the error in my environment, but I'm not sure which tests are required to validate it. I'm also unsure how files were created on the EmptyDir before init. Possibly a successful init previously, then a restart on the same node.

[kate-osborn]

@pl4nty thanks for the PR!

Instead of adding -p flag to the mkdir commands, can you clear out or remove the directories before creating them? I'd like to avoid having out-of-date or invalid configs in these directories after a restart.

[pl4nty]

Thanks @kate-osborn, how's this? Just removes the stale config if present. I've tested successfully on my dev cluster

[kate-osborn]

Thanks @kate-osborn, how's this? Just removes the stale config if present. I've tested successfully on my dev cluster

LGTM!

[pleshakov]

Hi @pl4nty

There is a small problem in the script -- please see the review comment with the fix suggestion.

Could you also rebase your branch against the latest main?

[kate-osborn]

@pl4nty the commit history on this PR has several commits from the main branch which is making the diff incorrect. Can you do an interactive rebase on main and squash all the commits into a single commit? That should fix the diff. Thanks!

[pl4nty]

@kate-osborn apologies, I was away for a while. Thanks for your patience!