Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conformance profile upload #2932

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

lucacome
Copy link
Member

Proposed changes

Fixes the condition to upload the conformance profile

Closes #2786

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner December 19, 2024 16:58
@github-actions github-actions bot added the chore Pull requests for routine tasks label Dec 19, 2024
.github/workflows/conformance.yml Outdated Show resolved Hide resolved
.github/workflows/conformance.yml Show resolved Hide resolved
@lucacome lucacome force-pushed the chore/upload-profile branch 2 times, most recently from bcc50c1 to 9311828 Compare December 19, 2024 17:41
@lucacome lucacome force-pushed the chore/upload-profile branch from 9311828 to d87296e Compare December 19, 2024 17:44
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.72%. Comparing base (6ab4a5d) to head (b286b88).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2932      +/-   ##
==========================================
- Coverage   89.74%   89.72%   -0.03%     
==========================================
  Files         109      109              
  Lines       11150    11150              
  Branches       50       50              
==========================================
- Hits        10007    10004       -3     
- Misses       1083     1085       +2     
- Partials       60       61       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome requested a review from sjberman December 19, 2024 19:40
@lucacome lucacome merged commit e26c82a into nginx:main Dec 19, 2024
40 checks passed
@lucacome lucacome deleted the chore/upload-profile branch December 19, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Conformance report upload was skipped during release
3 participants