Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance report upload was skipped during release #2786

Closed
sjberman opened this issue Nov 20, 2024 · 0 comments · Fixed by #2932
Closed

Conformance report upload was skipped during release #2786

sjberman opened this issue Nov 20, 2024 · 0 comments · Fixed by #2932
Assignees
Labels
bug Something isn't working refined Requirements are refined and the issue is ready to be implemented. release-engineering Relates to all release engineering tasks
Milestone

Comments

@sjberman
Copy link
Collaborator

The last step of the conformance pipeline during a release is to upload the report to the release page. This step was skipped for some reason on all conformance jobs during our last release. The current condition to run it looks like:

- name: Upload profile to release
   if: ${{ startsWith(github.ref, 'refs/tags/') && inputs.enable-experimental == 'true' }}

which means that if the pipeline is running due to being triggered from a release tag, and the conformance test run enables experimental features (noted by the workflow name having the true boolean in it, like Conformance tests (nginx, v1.31.1, true)), then a report should be uploaded to the release. This condition must have failed for some reason.

Here is a sample job that should have uploaded the report: https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/11941492077/job/33286876541

The inputs.enable-experimental appears to be true, so the github.ref condition may be the culprit here, although it seemed to have worked in other workflows. This needs some investigation as to why the job was skipped.

@sjberman sjberman added the release-engineering Relates to all release engineering tasks label Nov 20, 2024
@sjberman sjberman added this to the v1.6.0 milestone Nov 20, 2024
@mpstefan mpstefan added bug Something isn't working refined Requirements are refined and the issue is ready to be implemented. labels Nov 25, 2024
@lucacome lucacome self-assigned this Dec 19, 2024
@lucacome lucacome moved this to ✅ Done in NGINX Gateway Fabric Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refined Requirements are refined and the issue is ready to be implemented. release-engineering Relates to all release engineering tasks
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants