Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing variable in NFR script #2927

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Add missing variable in NFR script #2927

merged 2 commits into from
Dec 19, 2024

Conversation

lucacome
Copy link
Member

Proposed changes

Adds missing PLUS_USAGE_ENDPOINT in the script calling the Makefile.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner December 18, 2024 16:30
@github-actions github-actions bot added chore Pull requests for routine tasks tests Pull requests that update tests labels Dec 18, 2024
@lucacome lucacome enabled auto-merge (squash) December 18, 2024 16:32
@lucacome lucacome merged commit 8cf2608 into main Dec 19, 2024
40 checks passed
@lucacome lucacome deleted the chore/nfr branch December 19, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants